Skip to content

Commit

Permalink
chore: run apt update on docker user images (#213)
Browse files Browse the repository at this point in the history
Signed-off-by: ThibaultFy <[email protected]>
  • Loading branch information
ThibaultFy authored May 28, 2024
1 parent 354df22 commit cdac19c
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions changes/213.changed
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add `apt update` to docker user images to limit vulnerabilities.
3 changes: 3 additions & 0 deletions substrafl/remote/register/register.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@
DOCKERFILE_TEMPLATE = """
FROM {docker_image}
# update image
RUN apt update -y
# install dependencies
RUN python{python_version} -m pip install -U pip
Expand Down
3 changes: 3 additions & 0 deletions tests/remote/register/test_register.py
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,9 @@ def test_create_dockerfile(tmp_path, mocker, local_installable_module):
expected_dockerfile = f"""
FROM substratools-mocked
# update image
RUN apt update -y
# install dependencies
RUN python{python_version} -m pip install -U pip
Expand Down

0 comments on commit cdac19c

Please sign in to comment.