Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect translation of 'archiefnominatie' #251

Open
haarlem-dvh opened this issue Sep 14, 2021 · 0 comments
Open

Incorrect translation of 'archiefnominatie' #251

haarlem-dvh opened this issue Sep 14, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@haarlem-dvh
Copy link
Collaborator

I think that I have found two bugs.

var result = archiefNominatie.toUpperCase().equals("J") ? "vernietigen" : "blijvend_bewaren";

When there is no archiefNominatie
<archiefnominatie xsi:nil="true" stuf:noValue="geenWaarde" />

The value is set to 'blijvend_bewaren'. This should be set to 'null' as it is not a mandatory field in ZGW.

Also, I think that the ternary is the wrong way around. "J" should leed to "blijvend_bewaren".

@haarlem-dvh haarlem-dvh added the bug Something isn't working label Sep 14, 2021
@haarlem-dvh haarlem-dvh self-assigned this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant