Handle the initial protocol fees correctly, and add a 'pool creation fee' for additional protocol revenue #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fee' for additional protocol revenue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a hard-coded constant of 2 ADA that we subtracted off the reserves; This was cludgy, and also didn't account for what happened if someone set the
protocol_feesin the output datum to some weird number.Here, we subtract off the initial protocol fees, so that the LP token amounts get calculated correctly.
We also take the opportunity to add a protocol setting for the minimum initial value for this parameter; this effectively lets the DAO vote to institute an initial fee for each opened pool, which could limit spam and/or serve as another source of protocol revenue.