fix(Realtime): unsubscribe from all callbacks if no callback is provided

SuperViz · Oct 23, 2024 · 134ecaa · 134ecaa
1 parent 6307f8a
commit 134ecaa
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/realtime/src/services/channel/channel.test.ts b/packages/realtime/src/services/channel/channel.test.ts
@@ -1,10 +1,10 @@
 import { LIMITS_MOCK } from '../../../__mocks__/limits.mock';
 import { MOCK_OBSERVER_HELPER } from '../../../__mocks__/observer-helper.mock';
 import { MOCK_LOCAL_PARTICIPANT } from '../../../__mocks__/participants.mock';
+import { RealtimeChannelState } from '../../component/types';
 import { IOC } from '../io';
 
 import { Channel } from './channel';
-import { RealtimeChannelState } from '../../component/types';
 
 jest.mock('lodash/throttle', () => jest.fn((fn) => fn));
 jest.useFakeTimers();
@@ -78,6 +78,15 @@ describe('Realtime Channel', () => {
 
       expect(spy).toHaveBeenCalled();
     });
+
+    test('should reset an event if no callback is provided', () => {
+      ChannelInstance['observers']['test'] = MOCK_OBSERVER_HELPER;
+      const spy = jest.spyOn(ChannelInstance['observers']['test'], 'reset' as any);
+
+      ChannelInstance.unsubscribe('test');
+
+      expect(spy).toHaveBeenCalled();
+    });
   });
 
   describe('subscribeToRealtimeEvents', () => {

diff --git a/packages/realtime/src/services/channel/channel.ts b/packages/realtime/src/services/channel/channel.ts
@@ -110,6 +110,11 @@ export class Channel extends Observable {
     event: string,
     callback?: Callback<T>,
   ): void => {
+    if (!callback) {
+      this.observers[event]?.reset();
+      return;
+    }
+
     this.observers[event]?.unsubscribe(callback);
   };