Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Supernaut.FX using https://avaje.io/inject #10

Open
msgilligan opened this issue Feb 7, 2021 · 4 comments
Open

Implement Supernaut.FX using https://avaje.io/inject #10

msgilligan opened this issue Feb 7, 2021 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@msgilligan
Copy link
Member

msgilligan commented Feb 7, 2021

It looks like Avaje Inject will solve some of our jlink issues -- by using jakarta.inject and being fully modular.

We should be able to create a new module that implements the FXLauncher interface using Avaje Inject. If we do that (and switch to a modular logger API) we may be able to build apps without doing the extensive reprocessing of JARs with the Badass Jlink Gradle Plugin.

@msgilligan
Copy link
Member Author

Commit ecbd167 upgraded to Micronaut 2.4.0 and jakarta.inject 😁

@msgilligan msgilligan added the help wanted Extra attention is needed label Jan 7, 2022
@msgilligan
Copy link
Member Author

I would love to see a Pull Request that add a new module with an Avaje Inject implementation of the FXLauncher interface.

Such an implementation should probably be able to subclass FxLauncherAbstract.

@aalmiray?

@aalmiray
Copy link

aalmiray commented Jan 7, 2022

I'd have to do a deep dive into both avaje-di and micronaut-inject before. Been pretty busy polishing JReleaser for the golden 1.0 these days.

@msgilligan
Copy link
Member Author

... before. Been pretty busy ...

I tagged you mostly to make you aware I had created an issue for this.

(I'd much rather you look at integrating Supernaut.FX with Griffon, if you have any extra time. Hopefully, Supernaut.FX would provide you with a useful abstraction layer for multiple DI implementations. I'm really looking forward to hearing if you think this might work.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants