Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

~.importshops permission node is not correctly documented #12

Open
sudojunior opened this issue Sep 3, 2020 · 1 comment
Open

~.importshops permission node is not correctly documented #12

sudojunior opened this issue Sep 3, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@sudojunior
Copy link
Contributor

The permission node slabbo.importshops is tied to the command it was intended for, but it's permission node has either been removed or has never existed in the plugin config.

424d70a - UShops compatibility was added.
@Sven65
Copy link
Owner

Sven65 commented Sep 3, 2020

Checking the source, it does exist on the command itself, and is automatically added by ACF to the plugin permission config.

Adding it into the plugin.yml might be a good idea though.

@Sven65 Sven65 added the documentation Improvements or additions to documentation label Mar 10, 2021
@Sven65 Sven65 added good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed labels Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sudojunior @Sven65