Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show typing #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

show typing #57

wants to merge 1 commit into from

Conversation

pratishrai
Copy link

Display bot is typing while it's fetching the lyrics

@pratishrai pratishrai requested a review from flabbet as a code owner October 1, 2020 16:34
@pep8speaks
Copy link

Hello @pratishrai! Thanks for opening this PR.

Line 92:66: W291 trailing whitespace
Line 117:13: E128 continuation line under-indented for visual indent

Do see the Hitchhiker's guide to code style

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #57 into master will decrease coverage by 0.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #57      +/-   ##
==========================================
- Coverage   28.70%   28.61%   -0.10%     
==========================================
  Files           9        9              
  Lines         310      311       +1     
==========================================
  Hits           89       89              
- Misses        221      222       +1     
Impacted Files Coverage Δ
SwagLyricsBot/general_commands.py 41.93% <0.00%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f953705...a3bdcde. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants