Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite the _init_logdir function according to FIXME #674

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Rewrite the _init_logdir function according to FIXME #674

wants to merge 2 commits into from

Conversation

Puiching-Memory
Copy link
Contributor

Description

依据Todo Tree中提示的FixME,重写 _init_logdir函数.

  1. 补充了注释
  2. 修改了函数输入类型和返回类型
  3. 简并了错误捕获代码

NOTE: 尚未运行测试
NOTE NOTE: 各处的FIXME 提供的信息较为精简,很难确定具体的问题是什么

@SAKURA-CAT
Copy link
Contributor

我先写一个自动化测试workflow，方便提交pr时完成测试。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SAKURA-CAT SAKURA-CAT Awaiting requested review from SAKURA-CAT

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Puiching-Memory @SAKURA-CAT