Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swipe view won't reset if incorrect boundaries on touchend and mouseup events #5

Open
Dinushasilva opened this issue Apr 13, 2020 · 1 comment

Comments

@Dinushasilva
Copy link

Dinushasilva commented Apr 13, 2020

Hi,

First of all thank you for this amazing component,

swipeable-tabs-issue

Please check my PR for the fix #4 @shreya0712

Thanks!
Dinusha

@shreya0712
Copy link
Collaborator

Once the pointer goes out of the container where touch event listeners are attached, the events arent captured. Therefore, it doesnt move the views any further, making them appear stuck. All works smooth as long as the swipe actions are limited within the tab containers.

We need to detect when the pointer goes outside the container while the mouse is clicked(ie during touchmove/mousemove events), and reset the swipe when that happens. Unfortunately I haven't been able to find a way to do that.

Thanks for the PR @Dinushasilva , but I'm afraid it doesn't help !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants