Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose gitlab and gitlab registry URL in the gateway #628

Open
Panaetius opened this issue Feb 7, 2023 · 0 comments
Open

Expose gitlab and gitlab registry URL in the gateway #628

Panaetius opened this issue Feb 7, 2023 · 0 comments

Comments

@Panaetius
Copy link
Member

In the renku CLI for session start, we need to know where gitlab and especially the gitlab image registry is located, so we can poll the notebook service on if an image is built.

Currently, the CLi logs in like renku login <renku deployment url>, e.g. renku login renkulab.io and it then just guesses that the registry is at registry.<renku deployment url> and gitlab at gitlab.<renku deployment url>. In the case of our CI deployments or any other case where an external gitlab is used, this would not work, causing CLI commands that need this information to fail.

Since we can't access the helm values from a local CLI, we need to expose those URLs somewhere in the renku deployment so the CLI can get them. The gateway is the candidate that makes the most sense for this, as it's already the central entrypoint into the application, so we should expose this under some endpoint on the gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant