Change to shortened, typed v2 URLs #3504

ciyer · 2025-01-23T16:42:46Z

Move V2 URLs to new locations

/v2/help -> /help
/v2/connected-services -> /connected-services
/v2/groups -> /g
/v2/projects -> /p
/v2/search -> /search
/v2/secrets -> /secrets
/v2/user -> /user
/v2/users -> /u

/deploy renku=ciyer/urls-v1-v2

RenkuBot · 2025-01-23T16:43:35Z

You can access the deployment of this PR at https://renku-ci-ui-3504.dev.renku.ch

leafty

Looks good for the most part, see comments below:

client/src/features/dashboardV2/DashboardV2.tsx

client/src/features/groupsV2/new/GroupNew.tsx

client/src/features/groupsV2/settings/GroupSettingsMetadata.tsx

client/src/features/platform/components/StatusBanner.tsx

client/src/features/rootV2/RootV2.tsx

leafty · 2025-02-03T08:46:17Z

client/src/routing/routes.constants.ts

-      show: "/v2/users/:username",
-    },
+    root: "/",
+    connectedServices: "/connected-services",


Maybe this should be /integrations now. Can you ask the product team?

Still waiting for a response from the product team on this. It can be fixed in a follow-up if desired.

Fixed in af33b92

leafty

Last comments 😅

client/scripts/generate_sitemap.sh

leafty · 2025-02-03T12:39:42Z

client/src/features/groupsV2/new/GroupNew.tsx

+  const domain = params?.BASE_URL
+    ? new URL(params.BASE_URL).hostname
+    : "renkulab.io";
+  const baseUrl = `${domain}/g/`;


Why strip the scheme from the URL? This is not a valid URL (as a URL MUST start with a scheme).

Why is the code falling back to renkulab.io? window.location.origin provides a sane fall back.

It would be good to avoid hard-coding /g/. The route constants could be used to avoid having to remember routing leaks here too.

Fixed in 2f9fb33

client/src/features/rootV2/RootV2.tsx

leafty

LGTM

RenkuBot · 2025-02-05T10:18:41Z

Tearing down the temporary RenkuLab deplyoment for this PR.

* /v2/help -> /help * /v2/connected-services -> /integrations * /v2/groups -> /g * /v2/projects -> /p * /v2/search -> /search * /v2/secrets -> /secrets * /v2/user -> /user * /v2/users -> /u

ciyer had a problem deploying to renku-ci-ui-3504 January 23, 2025 16:43 — with GitHub Actions Failure

ciyer force-pushed the ciyer/urls-v2-typed branch from 6fb7d7c to 51ed7d0 Compare January 23, 2025 16:50

ciyer temporarily deployed to renku-ci-ui-3504 January 23, 2025 16:51 — with GitHub Actions Inactive

ciyer force-pushed the ciyer/urls-v2-typed branch from 51ed7d0 to 00f8d5b Compare January 23, 2025 17:00

ciyer temporarily deployed to renku-ci-ui-3504 January 23, 2025 17:00 — with GitHub Actions Inactive

ciyer force-pushed the ciyer/urls-v2-typed branch from 00f8d5b to b5228f2 Compare January 24, 2025 13:17

ciyer temporarily deployed to renku-ci-ui-3504 January 24, 2025 13:17 — with GitHub Actions Inactive

ciyer force-pushed the ciyer/urls-v2-typed branch from b5228f2 to 777be3e Compare January 24, 2025 14:09

ciyer temporarily deployed to renku-ci-ui-3504 January 24, 2025 14:09 — with GitHub Actions Inactive

ciyer force-pushed the ciyer/urls-v2-typed branch from 777be3e to e7a2907 Compare January 30, 2025 12:06

ciyer temporarily deployed to renku-ci-ui-3504 January 30, 2025 12:06 — with GitHub Actions Inactive

ciyer temporarily deployed to renku-ci-ui-3504 January 30, 2025 12:20 — with GitHub Actions Inactive

ciyer force-pushed the ciyer/urls-v2-typed branch from e7a2907 to 10d3e35 Compare January 30, 2025 13:00

ciyer temporarily deployed to renku-ci-ui-3504 January 30, 2025 13:00 — with GitHub Actions Inactive

ciyer force-pushed the ciyer/urls-v2-typed branch from 10d3e35 to b522811 Compare January 30, 2025 16:33

ciyer temporarily deployed to renku-ci-ui-3504 January 30, 2025 16:33 — with GitHub Actions Inactive

ciyer changed the base branch from build/urls-v1-v2 to ciyer/move-v1-urls January 31, 2025 09:31

ciyer temporarily deployed to renku-ci-ui-3504 January 31, 2025 09:31 — with GitHub Actions Inactive

Base automatically changed from ciyer/move-v1-urls to build/urls-v1-v2 January 31, 2025 10:44

ciyer force-pushed the ciyer/urls-v2-typed branch from b522811 to 9acd5ca Compare January 31, 2025 10:51

ciyer temporarily deployed to renku-ci-ui-3504 January 31, 2025 10:52 — with GitHub Actions Inactive

ciyer force-pushed the build/urls-v1-v2 branch from 75b525d to 9b32170 Compare January 31, 2025 11:09

refactor: adopt v2-centric URL scheme

8727938

ciyer force-pushed the ciyer/urls-v2-typed branch from 9acd5ca to 8727938 Compare January 31, 2025 11:09

ciyer temporarily deployed to renku-ci-ui-3504 January 31, 2025 11:09 — with GitHub Actions Inactive

fix rendering of footer

7b941f8

ciyer had a problem deploying to renku-ci-ui-3504 January 31, 2025 12:01 — with GitHub Actions Failure

ciyer temporarily deployed to renku-ci-ui-3504 January 31, 2025 12:32 — with GitHub Actions Inactive

ciyer temporarily deployed to renku-ci-ui-3504 January 31, 2025 13:31 — with GitHub Actions Inactive

leafty reviewed Feb 3, 2025

View reviewed changes

update sitemap

1802807

ciyer temporarily deployed to renku-ci-ui-3504 February 3, 2025 08:48 — with GitHub Actions Inactive

responding to PR review

df3eff7

ciyer temporarily deployed to renku-ci-ui-3504 February 3, 2025 09:05 — with GitHub Actions Inactive

show accurate base urls

f1baf3c

ciyer temporarily deployed to renku-ci-ui-3504 February 3, 2025 10:17 — with GitHub Actions Inactive

ciyer linked an issue Feb 3, 2025 that may be closed by this pull request

The URL for new projects should not be hard-coded #3517

Open

leafty reviewed Feb 3, 2025

View reviewed changes

ciyer had a problem deploying to renku-ci-ui-3504 February 4, 2025 10:18 — with GitHub Actions Failure

ciyer added 2 commits February 4, 2025 11:27

responding to PR review

0454df4

improve display of slug url

2f9fb33

ciyer force-pushed the ciyer/urls-v2-typed branch from a489f19 to 2f9fb33 Compare February 4, 2025 10:28

ciyer had a problem deploying to renku-ci-ui-3504 February 4, 2025 10:29 — with GitHub Actions Error

ciyer had a problem deploying to renku-ci-ui-3504 February 4, 2025 10:34 — with GitHub Actions Failure

rename connectedServices to integrations

af33b92

ciyer force-pushed the ciyer/urls-v2-typed branch from 7bc282a to af33b92 Compare February 4, 2025 10:41

ciyer had a problem deploying to renku-ci-ui-3504 February 4, 2025 10:41 — with GitHub Actions Failure

ciyer had a problem deploying to renku-ci-ui-3504 February 5, 2025 08:51 — with GitHub Actions Failure

ciyer had a problem deploying to renku-ci-ui-3504 February 5, 2025 08:57 — with GitHub Actions Failure

ciyer temporarily deployed to renku-ci-ui-3504 February 5, 2025 09:20 — with GitHub Actions Inactive

ciyer added 2 commits February 5, 2025 10:46

fix alignment of 'Customize URL' button

ac3467e

fix home link on not found page

ad90432

ciyer deployed to renku-ci-ui-3504 February 5, 2025 09:50 — with GitHub Actions View deployment

leafty self-requested a review February 5, 2025 10:13

leafty approved these changes Feb 5, 2025

View reviewed changes

ciyer merged commit d5dd04b into build/urls-v1-v2 Feb 5, 2025
19 checks passed

ciyer deleted the ciyer/urls-v2-typed branch February 5, 2025 10:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change to shortened, typed v2 URLs #3504

Change to shortened, typed v2 URLs #3504

ciyer commented Jan 23, 2025 •

edited

Loading

RenkuBot commented Jan 23, 2025

leafty left a comment

leafty Feb 3, 2025

ciyer Feb 3, 2025

ciyer Feb 4, 2025 •

edited

Loading

leafty left a comment

leafty Feb 3, 2025

ciyer Feb 5, 2025

leafty left a comment

RenkuBot commented Feb 5, 2025

Change to shortened, typed v2 URLs #3504

Change to shortened, typed v2 URLs #3504

Conversation

ciyer commented Jan 23, 2025 • edited Loading

Move V2 URLs to new locations

RenkuBot commented Jan 23, 2025

leafty left a comment

Choose a reason for hiding this comment

leafty Feb 3, 2025

Choose a reason for hiding this comment

ciyer Feb 3, 2025

Choose a reason for hiding this comment

ciyer Feb 4, 2025 • edited Loading

Choose a reason for hiding this comment

leafty left a comment

Choose a reason for hiding this comment

leafty Feb 3, 2025

Choose a reason for hiding this comment

ciyer Feb 5, 2025

Choose a reason for hiding this comment

leafty left a comment

Choose a reason for hiding this comment

RenkuBot commented Feb 5, 2025

ciyer commented Jan 23, 2025 •

edited

Loading

ciyer Feb 4, 2025 •

edited

Loading