Skip to content

Commit

Permalink
bug #40 Remove duplicated ClassAttributesSeparationFixer and use defa…
Browse files Browse the repository at this point in the history
…ult config (LucaGallinari)

This PR was merged into the 4.0-dev branch.

Discussion
----------

Sorry but there was an error in the previous PR. The ClassAttributesSeparationFixer is specified twice and the [upgrade.md ](https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/3.0/UPGRADE-v3.md)file was misleading: `['elements' => ['method']]` is not a valid config for this fixer.
Btw the default config is ok https://cs.symfony.com/doc/rules/class_notation/class_attributes_separation.html so we can avoid to specify a custom configuration for this fixer.

Commits
-------

ed9634a Remove duplicated ClassAttributesSeparationFixer and use default config
  • Loading branch information
Zales0123 authored Sep 16, 2021
2 parents 8c52560 + ed9634a commit 50b55dc
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions ecs.php
Original file line number Diff line number Diff line change
Expand Up @@ -189,9 +189,6 @@
$services->set(ClassDefinitionFixer::class)
->call('configure', [['single_item_single_line' => true, 'multi_line_extends_each_single_line' => true]]);

$services->set(ClassAttributesSeparationFixer::class)
->call('configure', [['elements' => ['method']]]);

$services->set(NoBlankLinesAfterClassOpeningFixer::class);

$services->set(NoNullPropertyInitializationFixer::class);
Expand Down

0 comments on commit 50b55dc

Please sign in to comment.