Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wget is unreliable in some environments #292

Open
richard087 opened this issue Dec 2, 2024 · 1 comment · May be fixed by #293
Open

wget is unreliable in some environments #292

richard087 opened this issue Dec 2, 2024 · 1 comment · May be fixed by #293
Labels
bug Something isn't working, either in /adalflow, /tutorials, or /use cases...

Comments

@richard087
Copy link

richard087 commented Dec 2, 2024 •
edited
Loading

Bug description

On my windows machine I experienced a crash when running code from https://colab.research.google.com/github/SylphAI-Inc/AdalFlow/blob/main/notebooks/qas/adalflow_object_count_auto_optimization.ipynb#scrollTo=-Gvfcy2IcgWx

What version are you seeing the problem on?

0.2.6

How to reproduce the bug

from adalflow.datasets.big_bench_hard import BigBenchHard
from adalflow.utils.data import subset_dataset

def check_datasets():
    train_data, val_data, test_data = load_datasets(max_samples=2)
    print(train_data[0])

check_datasets()

Error messages and logs

PS F:\code\ollama-test> & f:/code/ollama-test/.venv/Scripts/python.exe f:/code/ollama-test/test_adalflow.py
Downloading dataset to C:\Users\Richard\AppData\Roaming\adalflow\cache_datasets\object_counting\object_counting.json
Traceback (most recent call last):
  File "F:\code\ollama-test\.venv\Lib\site-packages\adalflow\datasets\big_bench_hard.py", line 79, in _check_or_download_dataset
    result = subprocess.call(
             ^^^^^^^^^^^^^^^^
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\subprocess.py", line 389, in call
    with Popen(*popenargs, **kwargs) as p:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\subprocess.py", line 1026, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.2544.0_x64__qbz5n2kfra8p0\Lib\subprocess.py", line 1538, in _execute_child
    hp, ht, pid, tid = _winapi.CreateProcess(executable, args,
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
FileNotFoundError: [WinError 2] The system cannot find the file specified

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "f:\code\ollama-test\test_adalflow.py", line 118, in <module>
    check_datasets()
  File "f:\code\ollama-test\test_adalflow.py", line 115, in check_datasets
    train_data, val_data, test_data = load_datasets(max_samples=2)
                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "f:\code\ollama-test\test_adalflow.py", line 102, in load_datasets
    train_data = BigBenchHard(split="train")
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "F:\code\ollama-test\.venv\Lib\site-packages\adalflow\datasets\big_bench_hard.py", line 56, in __init__
    self._check_or_download_dataset(data_path, split)
  File "F:\code\ollama-test\.venv\Lib\site-packages\adalflow\datasets\big_bench_hard.py", line 103, in _check_or_download_dataset
    raise ValueError(
ValueError: Either network issues or an incorrect task name: 'object_counting'.
Please verify the task name (the JSON file name) by checking the following link:
https://github.com/suzgunmirac/BIG-Bench-Hard/tree/main/bbh

Environment

  • OS: Windows

More info

Likely to effect slimmed down Docker images like python:slim.
@richard087 richard087 added the bug Something isn't working, either in /adalflow, /tutorials, or /use cases... label Dec 2, 2024
@richard087
Copy link
Author

exists here in main

AdalFlow/adalflow/adalflow/datasets/big_bench_hard.py

Lines 79 to 86 in e750721

result = subprocess.call(
[
"wget",
f"https://raw.githubusercontent.com/suzgunmirac/BIG-Bench-Hard/main/bbh/{self.task_name}.json",
"-O",
json_path,
]
)

@richard087 richard087 linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working, either in /adalflow, /tutorials, or /use cases...
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove wget. replaces with the python native "requests" library richard087/AdalFlow
1 participant
@richard087