Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing to fork from sphinx-material #46

Open
daniellimws opened this issue Feb 21, 2021 · 10 comments
Open

Consider changing to fork from sphinx-material #46

daniellimws opened this issue Feb 21, 2021 · 10 comments
Labels
documentation Improvements or additions to documentation

Comments

@daniellimws
Copy link
Collaborator

daniellimws commented Feb 21, 2021

A few months back @mgielda mentioned that there is a better sphinx material theme at https://github.com/bashtage/sphinx-material. It is a lot better than the one we are currently using, as the current one uses MDL which is already deprecated and has various css problems at times. The Symbiflow examples documentation page has changed to use this theme.

I made a fork of the sphinx-material theme to include the things we added (e.g. symbiflow-related links at the header and footer).

@mithro What do you think about changing to this theme? From trying it out, it doesn't seem to have those weird css problems that we used to have, and everything also seems to load faster. We could make a new repo called sphinx_symbiflow_theme_v2 if we are worried about breaking any existing documentation sites using this theme. But I've tried it on some existing repos and so far they work without needing to change anything in conf.py, so we could also consider just replacing everything in this repo.

Only thing we need to manually set is the theme color.

@issuelabeler issuelabeler bot added the documentation Improvements or additions to documentation label Feb 21, 2021
@mithro
Copy link
Member

mithro commented Feb 21, 2021

I'm all for moving to the theme @mgielda identified once we have added the set of features we added to the old theme.

@mithro
Copy link
Member

mithro commented Feb 21, 2021

@daniellimws -- I'm unsure if we have a list anywhere of the features missing in the new theme?

@daniellimws
Copy link
Collaborator Author

@mithro I looked through the PRs made and have implemented all the features that I added. They are either CSS fixes which shouldn't be needed in the new theme, or symbiflow related links in the header and footer which I already added to my fork of the new theme.

@mithro
Copy link
Member

mithro commented Feb 21, 2021

@daniellimws Shall we give it a go then?

@mithro
Copy link
Member

mithro commented Feb 21, 2021

mithro pushed a commit to mithro/sphinx_symbiflow_theme-old that referenced this issue Feb 22, 2021
@daniellimws
Copy link
Collaborator Author

@mithro shall we close this?

@mithro
Copy link
Member

mithro commented Mar 1, 2021

@daniellimws Let's wait until we have deployed the theme everywhere?

@mithro
Copy link
Member

mithro commented Mar 1, 2021

@daniellimws
Copy link
Collaborator Author

daniellimws commented Mar 4, 2021

@mithro Sorry for the late response. I think we need to push the new theme to pypi asap. Can you do that?

@daniellimws
Copy link
Collaborator Author

Just remembered we never push to pypi, but just install from github directly. My bad :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants