Make signature generation more flexible by allowing relative URLs #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaelBrauner
changed the title
|
This configuration option would be great. I have a use case where I want to target to a completely different host running on another framework; the hosts endpoint then proxies the request (or rather re-creates it) to the Symfony Controller. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the PR regarding this issue: #136
In the current implementation, the UriSigner always generates an absolute URL when signing. However, this might not be the desired behavior in some cases.
This PR adds a configuration option (use_relative_path) to allow the use of relative URLs when generating signatures. By default, the option is set to false, which maintains the existing behavior of generating absolute URLs.