Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add DATA_SLICES #105

Merged
merged 1 commit into from
Sep 13, 2024
Merged

add DATA_SLICES #105

merged 1 commit into from
Sep 13, 2024

Conversation

casperdcl
Copy link
Member

@casperdcl casperdcl commented Sep 12, 2024

As per #91 (review)

Reduces config duplication & makes #104 <- #102 easier to use.

@casperdcl casperdcl self-assigned this Sep 12, 2024
@casperdcl casperdcl added the enhancement New feature or request label Sep 12, 2024
Copy link
Member

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I prefer to have data dependencies in petric.py, but we have some already anyway, so can just as well go ahead. Fine for me therefore.

@casperdcl casperdcl merged commit 667d2d7 into main Sep 13, 2024
2 checks passed
@casperdcl casperdcl deleted the data-slices branch September 13, 2024 14:22
casperdcl added a commit that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants