Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change target directory for deploys #17

Open
Nate-Wilkins opened this issue Jul 27, 2016 · 3 comments
Open

Change target directory for deploys #17

Nate-Wilkins opened this issue Jul 27, 2016 · 3 comments

Comments

@Nate-Wilkins
Copy link

Nate-Wilkins commented Jul 27, 2016

Would it be possible to remove this check?

if sys.argv[-1] == 'deploy':
    print('outdir option not allowed for deploy')
    sys.exit(2)

I'm unable to change the target directory on deploy which seems like a bug. Same with the --source option?

@Syntaf
Copy link
Owner

Syntaf commented Jul 27, 2016

Good point Nate, but is there any reason why you/others would need to change the output directory?

The reasoning for the unchangeable location is that I branched travis-sphinx originally from my Rust code, which if you aren't familiar with the language, it's internal documentation toolchain will always build to the target/doc/build dir.

@Nate-Wilkins
Copy link
Author

Hmm I guess just more of a convenience. I'm not really using Rust in my project and I guess for more control? Idk up to you 👍 I can submit a PR if you'd like

@halkeye
Copy link

halkeye commented Jun 16, 2017

I'll throw it out that you can build to a specific target directory, anywhere you want, but you can't deploy anywhere but that hard coded path.

It seems pretty easy and simple to remove that check and doesn't actually hurt anything from providing those two options for deploy and build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants