Issue #718: use command -v instead of checking status via '$?'

TACC · Sep 11, 2024 · 5daf994 · 5daf994
1 parent 897ee35
commit 5daf994
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/init/bash.in b/init/bash.in
@@ -25,8 +25,8 @@ fi
 
 __build_FPATH_for_zsh_ksh()
 {
-  (compinit -C 2> /dev/null)
-  if [ "$?" != 0 ]; then
+
+  if ! (compinit -C 2> /dev/null) ; then
     __zsh_fpath=$(unset FPATH; zsh -f -c 'echo $FPATH')
   fi
 
@@ -39,8 +39,7 @@ if [ -n "${ZSH_VERSION+x}" ]; then
 fi
 
 if [ -n "${KSH_VERSION+x}" -o -n "${BASH_VERSION+x}" ]; then
-  type zsh > /dev/null 2>&1
-  if [ "$?" = 0 ]; then
+  if command -v zsh > /dev/null; then
     __build_FPATH_for_zsh_ksh 
   else
     export FPATH=$(@PKGV@/libexec/addto --append FPATH ${FPATH:-} @PKGV@/init/ksh_funcs)