Allow middle-clicking the search button with progressive enhancement #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelikat
reviewed
Oct 14, 2024
TASVideos/wwwroot/js/site-head.js
Outdated
| // allow middle-clicking the search button to open in new tab | ||
| const searchBtnElem = document.querySelector(/*ul.navbar-nav */'form[action="/Search/Index"] button[type="submit"]'); | ||
| // is there a function for this? reverse Element.querySelector? | ||
| let searchFormElem = searchBtnElem.parentElement; |
There was a problem hiding this comment.
what happens if there is not a searchBtnElem on the page? this would be a javascript error. Also this runs on every page load. This needs to be fast, I'm not sure that query selector is. Adding an id would be okay I think.
I also don't like this approach, or possibly any approach, the complexity vs value I think is questionable
There was a problem hiding this comment.
Is the search bar not on every page? I could easily handle that case if not.
nattthebear
reviewed
Oct 30, 2024
thanks natt
|
I just remembered the search has a char limit, which isn't currently enforced client-side but could easily be added to this click handler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1878.
RetroEdit's earlier draft used JS to add an event handler specifically for MMB. I feel that's the wrong approach, and it should instead use the browser's built-in handling for
<a/>.This changeset uses JS to replace the
<button/>with an<a/>, then adds an event handler foronclick(which is a misnomer and is not specific to LMB) which restores the<button/>-like submit behaviour.