Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vite not stopping when ftl dev exits #2970

Closed
tomdaffurn opened this issue Oct 3, 2024 · 0 comments
Closed

Vite not stopping when ftl dev exits #2970

tomdaffurn opened this issue Oct 3, 2024 · 0 comments
Assignees
@stuartwdouglas
Labels
bug Something isn't working

Comments

@tomdaffurn
Copy link
Contributor

When an ftl dev process is stopped with Ctrl-C, the Vite instance it started keeps running, holding open a port.
@tomdaffurn tomdaffurn added the bug Something isn't working label Oct 3, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Oct 3, 2024
@ftl-robot ftl-robot mentioned this issue Oct 3, 2024
Open
stuartwdouglas added a commit that referenced this issue Oct 3, 2024
@stuartwdouglas
fix: readline exit behaviour
4a89a2b 
Send SIGINT so all processess in the group also shut down

fixes: #2970
@stuartwdouglas stuartwdouglas self-assigned this Oct 3, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartwdouglas stuartwdouglas

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stuartwdouglas @tomdaffurn