Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate uploaded artifacts at deployment #3250

Closed
jvmakine opened this issue Oct 30, 2024 · 1 comment
Closed

Validate uploaded artifacts at deployment #3250

jvmakine opened this issue Oct 30, 2024 · 1 comment
Labels
triage Issue needs triaging

Comments

@jvmakine
Copy link
Contributor

Currently, if we upload an invalid binary (compiled for incorrect architecture, for example) the deployment just hangs, and runner ends up in crash loop, with error

ftl-runner: error: failed to spawn plugin: plugin process died: context canceled

It would be a better user experience to check the binary is in correct format, and if not, return an error indicating that during the deployment.
@github-actions github-actions bot added the triage Issue needs triaging label Oct 30, 2024
@ftl-robot ftl-robot mentioned this issue Oct 30, 2024
Open
@alecthomas
Copy link
Collaborator

Duplicate of #1845

@alecthomas alecthomas marked this as a duplicate of #1845 Oct 30, 2024
@alecthomas alecthomas closed this as not planned Won't fix, can't repro, duplicate, stale Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Issue needs triaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alecthomas @jvmakine