Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console loads duplicate trace spans #3260

Closed
andresuribe87 opened this issue Oct 30, 2024 · 3 comments
Closed

Console loads duplicate trace spans #3260

andresuribe87 opened this issue Oct 30, 2024 · 3 comments
Assignees
@wesbillman
Labels
bug Something isn't working console Web console

Comments

@andresuribe87
Copy link
Contributor

andresuribe87 commented Oct 30, 2024 •
edited by wesbillman
Loading

Go to the traces view
Wait for 20ish seconds, go to other tabs.
The result is reloading the flame graph, which causes duplicate traces to appear
@github-actions github-actions bot added the triage Issue needs triaging label Oct 30, 2024
@ftl-robot ftl-robot mentioned this issue Oct 30, 2024
Open
@deniseli
Copy link
Contributor

pretty sure it's a simple js bug in the rendering template. I'll grab this next if wes doesn't beat me to it

@wesbillman wesbillman self-assigned this Oct 30, 2024
@wesbillman wesbillman added bug Something isn't working console Web console labels Oct 30, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Oct 30, 2024
@wesbillman
Copy link
Member

I think this is being caused by these errors

index-7hTRnJxG.js:280 useSchema - streamSchema - Connect error: ConnectError: [unknown] missing EndStreamResponse
    at Zt.from (index-7hTRnJxG.js:279:9628)
    at index-7hTRnJxG.js:280:41319Caused by: missing EndStreamResponse
index-7hTRnJxG.js:444 Console service - streamEvents - Connect error: ConnectError: [unknown] missing EndStreamResponse
    at Zt.from (index-7hTRnJxG.js:279:9628)
    at index-7hTRnJxG.js:280:41319Caused by: missing EndStreamResponse

I would guess that these lead to us re-requesting the events starting from the beginning after this happens. I wonder what is causing these errors though 🤔

This was referenced Oct 31, 2024
Open
Merged
wesbillman added a commit that referenced this issue Oct 31, 2024
@wesbillman
fix: clear events when streaming starts (#3266)
f8f8f44 
See #3260

We can get some console connection errors in our deployed environment
which causes streaming to get restarted. However, it seems like we don't
clear the cache when this happens so duplicate events get returned from
our streaming hooks. This change should ensure the events are cleared
anytime we restart the stream.
@wesbillman
Copy link
Member

The duplicate entries should be fixed with #3266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wesbillman wesbillman

Labels
bug Something isn't working console Web console
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wesbillman @andresuribe87 @deniseli