Move logical DB creation away from success status check #3333
Assignees
Comments
Open
jvmakine
added a commit
that referenced
this issue
Nov 6, 2024
Connects to the freshly created psql instance, and creates a database if it does not exist. This closes #3117 with tbdeng/ftl-aws#35 We should refactor the DB creation from the success step to be part of the actual provisioning flow. Thicket for this: #3333 We should also not use the root credentials when connecting to the DB from a module. However, we should change this when looking at DB migrations, when we won't expect modules to execute DDL anymore. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jvmakine
added a commit
that referenced
this issue
Nov 13, 2024
Previously, we were `CREATE DATABASE ... ` as a response to a successful status check. Now, we spawn a background goroutine to wait for the stack to become ready and run any DDL commands before reporting the task as a success. Closes #3333 --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Th DB creation should be part of the standard flow, not in a status check.
The text was updated successfully, but these errors were encountered: