Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: timeline events for pubsub #3322

Merged
merged 3 commits into from
Nov 6, 2024
Merged

feat: timeline events for pubsub #3322

merged 3 commits into from
Nov 6, 2024

Conversation

safeer
Copy link
Contributor

@safeer safeer commented Nov 4, 2024 •
edited
Loading

Screenshot 2024-11-04 at 11 18 42 AM

@safeer safeer requested review from a team and alecthomas as code owners November 4, 2024 19:38
@safeer safeer requested review from deniseli and removed request for a team November 4, 2024 19:38
This was referenced Nov 4, 2024
Open
Open
@safeer safeer changed the title feat: timeline events for pubsub events feat: timeline events for pubsub Nov 5, 2024
@safeer safeer force-pushed the saf/timeline_pubsub branch from c1ddc5a to 29a950b Compare November 5, 2024 00:49
wesbillman
wesbillman approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@wesbillman wesbillman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! Thanks @safeer ❤️

Love the 📡 icons too! 😄

@wesbillman wesbillman removed the request for review from deniseli November 5, 2024 16:11
@wesbillman wesbillman enabled auto-merge (squash) November 6, 2024 04:37
@wesbillman wesbillman merged commit 7e8abfa into main Nov 6, 2024
94 checks passed
@wesbillman wesbillman deleted the saf/timeline_pubsub branch November 6, 2024 16:26
@alecthomas
Copy link
Collaborator

Thanks @safeer 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesbillman wesbillman wesbillman approved these changes

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@safeer @alecthomas @wesbillman