Eirby/client side schema validation #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
EdwardIrby
commented
Aug 30, 2023
EdwardIrby
commented
- Adds schema validation into editor
- Fixes tabbing bug that was blocking dev on this
- needs styling adjustment on tab container to show top tool tip.
EdwardIrby
requested review from
alecthomas,
dhanji and
wesbillman
as code owners
Screen.Recording.2023-08-29.at.5.42.10.PM.mov |
Screen.Recording.2023-08-29.at.5.54.24.PM.mov |
EdwardIrby
force-pushed
the
eirby/client-side-schema-validation
branch
from
580dbaf to
eea57e8
Compare
|
The schema validation is so cool, thanks @EdwardIrby . |
alecthomas
reviewed
Aug 30, 2023
| if (modules.length) { | ||
| const ids = id.split('.') | ||
| // Handle edge case where the id contains and invalid module or verb | ||
| if (modules.length) { |
There was a problem hiding this comment.
There should be a check for ids.length == 2 somewhere here I think? Otherwise if it's 1 or >2 the array destructuring below will fail, no?
There was a problem hiding this comment.
It's in the invalidTab util https://github.com/TBD54566975/ftl/blob/main/console/client/src/utils/invalid-tab.utils.ts#L30-L35
wesbillman
approved these changes
Aug 30, 2023
Comment on lines
+85
to
+87
| schemas: [ | ||
| {schema, uri: 'http://myserver/foo-schema.json', fileMatch: ['*']}, | ||
| ], |
There was a problem hiding this comment.
Is there a valid uri we can use here? Or does this uri not really matter here?
…ide-schema-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.