Eirby/client side schema validation #337
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,8 +6,6 @@ import {ModuleDetails} from '../features/modules/ModuleDetails' | |
| import {ModulesList} from '../features/modules/ModulesList' | ||
| import {Timeline} from '../features/timeline/Timeline' | ||
| import {VerbTab} from '../features/verbs/VerbTab' | ||
| import { | ||
| NotificationType, | ||
| NotificationsContext, | ||
|
|
@@ -29,22 +27,18 @@ import { | |
| import {Navigation} from './Navigation' | ||
| import {Notification} from './Notification' | ||
| import {SidePanel} from './SidePanel' | ||
| import {modulesContext} from '../providers/modules-provider' | ||
| const selectedTabStyle = `${headerTextColor} ${headerColor}` | ||
| const unselectedTabStyle = `text-gray-300 bg-slate-100 dark:bg-slate-600` | ||
|
|
||
| export function IDELayout() { | ||
| const {modules} = React.useContext(modulesContext) | ||
| const {tabs, activeTab, setActiveTab, setTabs} = React.useContext(TabsContext) | ||
| const {showNotification} = React.useContext(NotificationsContext) | ||
| const [searchParams, setSearchParams] = useSearchParams() | ||
| const [activeIndex, setActiveIndex] = React.useState(0) | ||
| const id = searchParams.get(TabSearchParams.id) as string | ||
| const type = searchParams.get(TabSearchParams.type) as string | ||
|
|
||
| const handleCloseTab = (id: string, index: number) => { | ||
| const nextActiveTab = { | ||
|
|
@@ -70,63 +64,77 @@ export function IDELayout() { | |
| }) | ||
| } | ||
|
|
||
| // Handle loading a page with the tab query parameters | ||
| React.useEffect(() => { | ||
| const msg = invalidTab({id, type}) | ||
| if (msg) { | ||
| // Default fallback to timeline | ||
| setActiveTab({id: timelineTab.id, type: timelineTab.type}) | ||
| if (type === null && id === null) return | ||
|
|
||
| return showNotification({ | ||
| title: 'Invalid Tab', | ||
| message: msg, | ||
| type: NotificationType.Error, | ||
| }) | ||
| } | ||
| // Handle timeline tab id | ||
| if (id === timelineTab.id) { | ||
| return setActiveTab({id: timelineTab.id, type: timelineTab.type}) | ||
| } | ||
| if (modules.length) { | ||
| const ids = id.split('.') | ||
| // Handle edge case where the id contains and invalid module or verb | ||
| if (modules.length) { | ||
|
There was a problem hiding this comment. There should be a check for There was a problem hiding this comment. It's in the |
||
| const [moduleId, verbId] = ids | ||
| // Handle Module does not exist | ||
| const moduleExist = modules.find(module => module?.name === moduleId) | ||
| if (!moduleExist) { | ||
| showNotification({ | ||
| title: 'Module not found', | ||
| message: `Module '${moduleId}' does not exist`, | ||
| type: NotificationType.Error, | ||
| }) | ||
| return setActiveTab({id: timelineTab.id, type: timelineTab.type}) | ||
| } | ||
| // Handle Verb does not exists | ||
| const verbExist = moduleExist?.verbs.some( | ||
| ({verb}) => verb?.name === verbId | ||
| ) | ||
| if (!verbExist) { | ||
| showNotification({ | ||
| title: 'Verb not found', | ||
| message: `Verb '${verbId}' does not exist on module '${moduleId}'`, | ||
| type: NotificationType.Error, | ||
| }) | ||
| return setActiveTab({id: timelineTab.id, type: timelineTab.type}) | ||
| } | ||
| } | ||
| // Handle if tab is not already in tab list | ||
| if ( | ||
| !tabs.some( | ||
| ({id: tabId, type: tabType}) => tabId === id && tabType === type | ||
| ) | ||
| ) { | ||
| const newTab = { | ||
| id, | ||
| label: ids[1], | ||
| type: TabType.Verb, | ||
| } | ||
| const nextTabs = [...tabs, newTab] | ||
| setTabs(nextTabs) | ||
| return setActiveTab({id: newTab.id, type: newTab.type}) | ||
| } | ||
| // Handle if tab is in tab list | ||
| return setActiveTab({id, type}) | ||
| } | ||
| }, [id, type, modules]) | ||
|
|
||
| // Set active tab index whenever our activeTab context changes | ||
| React.useEffect(() => { | ||
| const index = tabs.findIndex(tab => tab.id === activeTab?.id) | ||
| setActiveIndex(index) | ||
| }, [activeTab]) | ||
|
|
||
| return ( | ||
| <> | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a valid
uriwe can use here? Or does thisurinot really matter here?