feat: propagate FTL headers through kotlin-runtime #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
force-pushed
the
aat/kt-headers
branch
2 times, most recently
from
e7f89d5 to
508606e
Compare
wesbillman
reviewed
Aug 30, 2023
kotlin-runtime/ftl-runtime/src/main/kotlin/xyz/block/ftl/server/ServerInterceptor.kt
Show resolved
Hide resolved
wesbillman
approved these changes
Aug 30, 2023
alecthomas
force-pushed
the
aat/kt-headers
branch
from
508606e to
f021bc8
Compare
There's some weirdness at play, in that the client uses okhttp3, and the server uses grpc.io. This appears to be how Wire works, but there's basically zero documentation so I can't be sure. Also switched to using bit for builds in scripts. Bit has much better dependency specificiation than make so, for example, when repeatedly running integration tests, it won't constantly rebuild the JARs.
alecthomas
force-pushed
the
aat/kt-headers
branch
from
f021bc8 to
2b897ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of this, switched to using plain gRPC for client calls (rather than okhttp).
Also switched to using bit for builds in scripts. Bit has much better
dependency specificiation than make so, for example, when repeatedly
running integration tests, it won't constantly rebuild the JARs.