Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: group logs in timeline #359

Closed
wants to merge 2 commits into from
Closed

feat: group logs in timeline #359

wants to merge 2 commits into from

Conversation

alecthomas
Copy link
Collaborator

@alecthomas alecthomas commented Sep 6, 2023 •
edited
Loading

I like it, but this has some issues:

  1. Because the log entries are in a sub-list, the closures that handle navigation and the sidebar don't work.
  2. I can't figure out how to make the lines extend for the height of the logs.
  3. Log lines should probably wrap.
  4. Timestamps aren't in a consistent location, they vary based on the length of log lines.

I think some of these were pre-existing, but some of them are definitely new.

grouped-logs

@alecthomas
feat: group logs in timeline
7060604 
I like it, but this has some issues:

1. Because the log entries are in a sub-list, the closures that handle
   navigation don't work.
2. I can't figure out how to make the lines extend for the height of the
   logs.
@alecthomas alecthomas closed this Sep 9, 2023
@alecthomas alecthomas deleted the aat/grouped-logs branch February 9, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhanji dhanji Awaiting requested review from dhanji

@wesbillman wesbillman Awaiting requested review from wesbillman

Assignees
No one assigned
Labels
None yet
Projects
No open projects
FTL
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alecthomas