Skip to content

Commit

Permalink
a few unrelated CI improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
finn-block committed Jun 13, 2024
1 parent 2db5478 commit 4bfb1e9
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 7 deletions.
3 changes: 2 additions & 1 deletion .github/generate-test-steps.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ for (const language of readdirSync('.')) {
}

examples.push({
name: example,
name: config.name || example,
directory: directory,
preTestCommands: preTestCommands,
testCommands: testCommands
});
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ jobs:
node-version: '20.4.0'
- name: test setup
run: ${{ matrix.example.preTestCommands }}
working-directory: javascript/${{ matrix.example.name }}
working-directory: ${{ matrix.example.directory }}
if: matrix.example.preTestCommands != null
- name: test
run: ${{ matrix.example.testCommands }}
working-directory: javascript/${{ matrix.example.name }}
working-directory: ${{ matrix.example.directory }}

kotlin:
name: Kotlin (${{ matrix.example.name }})
Expand Down Expand Up @@ -70,11 +70,11 @@ jobs:
uses: android-actions/setup-android@00854ea68c109d98c75d956347303bf7c45b0277 # v3.2.1
- name: test setup
run: ${{ matrix.example.preTestCommands }}
working-directory: kotlin/${{ matrix.example.name }}
working-directory: ${{ matrix.example.directory }}
if: matrix.example.preTestCommands != null
- name: test in android emulator
uses: reactivecircus/android-emulator-runner@77986be26589807b8ebab3fde7bbf5c60dabec32 # v2.31.0
with:
api-level: 29
script: ${{ matrix.example.testCommands }}
working-directory: kotlin/${{ matrix.example.name }}
working-directory: ${{ matrix.example.directory }}
2 changes: 1 addition & 1 deletion javascript/shared-todo/.tbd-example.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "Shared TODO (completed)",
"name": "Shared TODO",
"tests": {
"pre": ["npm install", "npx playwright install --with-deps"],
"command": "npm run test:browser"
Expand Down
2 changes: 1 addition & 1 deletion javascript/todo/.tbd-example.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "TODO (completed)",
"name": "TODO",
"tests": {
"pre": ["npm install", "npx playwright install --with-deps"],
"command": "npm run test:browser"
Expand Down

0 comments on commit 4bfb1e9

Please sign in to comment.