Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CODEOWNERS #7

Merged
merged 7 commits into from
Jun 17, 2024
Merged

add CODEOWNERS #7

merged 7 commits into from
Jun 17, 2024

Conversation

finn-block
Copy link
Member

@finn-block finn-block commented Jun 12, 2024

This repo is a collection of TBD examples from across our github. Most of them didn't have codeowners, so I've had to guess who was a good contact for each one. If you're listed, please let me know if you are a good codeowner for that example and if there should be any additional codeowners for it. I'll merge when I get confirmation from everyone.

@michaelneale
Copy link
Contributor

@finn-tbd I checked myself on them - but can we add a few others from the commit history?

@finn-block
Copy link
Member Author

For sure, I'm not seeing a lot of other committers for most of the ones you're a on @michaelneale but tbdex-pfi-exemplar seems to actually have it's own CODEOWNERS file that I missed, so I've copied everyone from there into here. Also added @jiyoontbd to tbdex-example-android

@michaelneale
Copy link
Contributor

at what point do we move examples to this repo vs maintain in others?

@finn-block
Copy link
Member Author

finn-block commented Jun 14, 2024

Should be good to start doing that any time, I was going to do it that next week. I'm planning to submit a PR to each of the other repos wiping out all files and replacing the README with a short message linking to the new location.

@blackgirlbytes
Copy link
Contributor

I agree with this. I think you can add me as an additional code owner for javascript/fan-club-credential

CODEOWNERS Outdated Show resolved Hide resolved
@acekyd
Copy link
Contributor

acekyd commented Jun 17, 2024

LGTM!

@finn-block finn-block merged commit 0b056c8 into main Jun 17, 2024
12 checks passed
@finn-block
Copy link
Member Author

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants