Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining package.json named exports causing compat issues #822

Open
shamilovtim opened this issue Aug 4, 2024 · 0 comments
Open
Assignees

Comments

@shamilovtim
Copy link
Contributor

The named package.json exports have caused issues with sinon, react native, bundlers, etc. They are easily replaced by simple object exports that namespace grouped functions. Afterwards, consider adding an eslint rule so the project is free of these in the future.

e.g.:

export const CryptoUtils = {
  randomPin,
  randomUuid,
  randomBytes,
  isWebCryptoSupported,
  getJoseSignatureAlgorithmFromPublicKey,
  checkValidProperty,
  checkRequiredProperty
};
@shamilovtim shamilovtim self-assigned this Aug 9, 2024
@shamilovtim shamilovtim removed this from the Wallet Connect Enhancements milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

1 participant