Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work plan and enhancement / 工作计划和用户诉求 #194

Open
zRzRzRzRzRzRzR opened this issue Aug 28, 2024 · 22 comments
Open

Work plan and enhancement / 工作计划和用户诉求 #194

zRzRzRzRzRzRzR opened this issue Aug 28, 2024 · 22 comments
Assignees
Labels
enhancement New feature or request

Comments

@zRzRzRzRzRzRzR
Copy link
Member

zRzRzRzRzRzRzR commented Aug 28, 2024

Tasks that have been identified and scheduled:

  • Fine-tuning support for Diffusers version models
  • Adaptation for CPU / NPU inference frameworks (e.g., Huawei, Intel devices)
  • ComfyUI adaptation work and plugin support

已经明确并排期的任务:

  • CogVideoX1.5 Diffusers版本适配
  • CogVideoX-Factory等生态工具的更新

如果你有更多诉求,欢迎在这里提出

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR pinned this issue Aug 28, 2024
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR added the enhancement New feature or request label Aug 28, 2024
@zRzRzRzRzRzRzR
Copy link
Member Author

zRzRzRzRzRzRzR commented Aug 28, 2024

#182 #191 #47 #84 have similar content, all looking forward to the open-source CogVideoX I2V model. We are conducting research and evaluation.

#111 #186 are similar, both expecting to provide fine-tuning work for VAE. We will try to place it in the fine-tuning version, and there is a probability that it can be adapted in diffusers fine-tuning, but it will consume relatively high resources

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR changed the title Our Plan / 我们的工作计划 Work plan and enhancement / 工作计划和用户诉求 Aug 28, 2024
@rookiemann
Copy link

5b image to video please! I2V would be lovely!

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR self-assigned this Aug 29, 2024
@PR-Ryan
Copy link

PR-Ryan commented Aug 30, 2024

The 3D VAE model consumes significantly more memory compared to diffusion models, which is severely limiting the batch size for fine-tuning. Any suggestions or optimizations to reduce memory usage would be greatly appreciated.

@zRzRzRzRzRzRzR
Copy link
Member Author

The 3D VAE model consumes significantly more memory compared to diffusion models, which is severely limiting the batch size for fine-tuning. Any suggestions or optimizations to reduce memory usage would be greatly appreciated.

You make a very good point. We will work together with the Diffusers team to modify the fake quantization (fakecp) process in the VAE section to optimize it for lower memory usage. Please give us some time, as we will collaborate with the Diffusers team to develop a version of the model that is fine-tuned specifically for Diffusers, which is expected to save a significant amount of memory.

@KihongK
Copy link

KihongK commented Sep 5, 2024

First of all, thank you for your excellent work!

The dataset format used SAT way for fine tuning & full training be the same as the format that will be used for fine-tuning Diffusers version models?

+ wrong discord link

@zRzRzRzRzRzRzR
Copy link
Member Author

We are currently completing several tasks

  1. Adaptation work for the I2V model, expected to be open-sourced in September
    Detailed tutorial on model fine-tuning, expected to be completed in September

Work that has been completed

  1. The model fine-tuned with SAT can be converted to a diffusers model and mounted directly. For specific usage, see here
  2. The new Discord invitation link will be merged into the main branch today

@sincerity711
Copy link

When will vertical video generation be supported?

@zRzRzRzRzRzRzR
Copy link
Member Author

When will vertical video generation be supported?

The current model cannot generate vertical videos, such as 480x720 resolution. We are working on fine-tuning to reach this capability, but it’s still in progress. Once we have any updates, we will share them as soon as possible.

@zRzRzRzRzRzRzR
Copy link
Member Author

Two related issues working now:

  1. Diffusers supports CogVideoX-I2V. This PR has been merged, but the patch has not yet been released.

  2. Fine-tuning the Diffusers version of CogVideoX-2B T2V without using the SAT model, running directly under the Diffusers framework. It can run on a single A100 GPU.
    This PR is still under debugging. I am working with members of the Diffusers team to attempt fine-tuning the CogVideoX-5B and I2V models. We will provide a small dataset (a few dozen samples) for this PR, which is sufficient for LoRA fine-tuning CogVideoX.

Many thanks to @a-r-r-o-w for the help with these two tasks!

@JH-Xie
Copy link

JH-Xie commented Sep 22, 2024

when will CogVideoX-2B-I2V be released?


@SanGilbert
Copy link

  1. Various resolution support. Maybe RoPE + resize data to random resolution will achieve this?
  2. Control ability of model, more than just text prompt.

@Florenyci
Copy link

@zRzRzRzRzRzRzR Many thanks to you and the team! I know fine-tuning vae is not very useful, but I'm curious is there any way I can just fine-tuning decoder part?

@zRzRzRzRzRzRzR
Copy link
Member Author

Our publicly available fine-tuning code is for the fine-tuning of the transformers part, not for vae. We indeed have not updated the training and fine-tuning parts of vae (because I have not received the corresponding permissions either).
Additionally, fine-tuning vae alone seems to have little significance for the overall model effect. If you want to try fine-tuning the diffusers model, all fine-tuning of the transformers module is already in dev, currently it is lora, and it is expected to implement SFT by early October.

@Florenyci
Copy link

Our publicly available fine-tuning code is for the fine-tuning of the transformers part, not for vae. We indeed have not updated the training and fine-tuning parts of vae (because I have not received the corresponding permissions either). Additionally, fine-tuning vae alone seems to have little significance for the overall model effect. If you want to try fine-tuning the diffusers model, all fine-tuning of the transformers module is already in dev, currently it is lora, and it is expected to implement SFT by early October.

@zRzRzRzRzRzRzR thank you but actually I'm asking how to fine-tuning VAE decoder, any advice?

@chenshuo20
Copy link

Hi @zRzRzRzRzRzRzR, what's your plan about diffuser I2V lora fine-tune code? Thanks!

@alfredplpl
Copy link

alfredplpl commented Oct 8, 2024

@zRzRzRzRzRzRzR

Thank you for your great works!

I would like to covert a full-finetuned 2b model weight in sat into a model weight in diffusers.
My full-finetuned model weight in sat is approx. 22GB.
Therefore, I do not convert the model by your conversion code: python ../tools/convert_weight_sat2hf.py.
This model weight may includes transformer and optimizer weight and so on.
Therefore, I tried to extract transformer from the model weight only.
However, something went on.

How can I do it?

@alfredplpl
Copy link

I could convert the full-finetuned weight into the diffusers weight.
We need extract limited keys by the script:

import torch

# ファイルAとファイルBのパス
file_a_path = 'file_a.pt'
file_b_path = 'file_b.pt'
file_c_path = 'file_c.pt'

# ファイルAをロードしてキーを取得
file_a = torch.load(file_a_path)

# ファイルBをロード
file_b = torch.load(file_b_path)

# 新しいファイルCに入れるデータを保存する辞書
file_c_data = {}

# 再帰的に辞書のキーに基づいて値を取り出す関数
def extract_values_from_b(a_dict, b_dict):
    result = {}
    for key, value in a_dict.items():
        if isinstance(value, dict):  # 値がさらに辞書の場合は再帰処理
            if key in b_dict and isinstance(b_dict[key], dict):
                result[key] = extract_values_from_b(value, b_dict[key])
            else:
                print(f"Key '{key}' not found or not a dict in file B")
        else:
            if key in b_dict:
                result[key] = b_dict[key]
            else:
                print(f"Key '{key}' not found in file B")
    return result

# ファイルAの構造に基づいてファイルBから値を取得
file_c_data = extract_values_from_b(file_a, file_b)

# 新しいファイルCに保存
torch.save(file_c_data, file_c_path)

print(f"New .pt file saved at: {file_c_path}")

Please feel free to ask me for further detail.

@dushwe
Copy link

dushwe commented Oct 15, 2024

video outpainting fintune scripts

@jumbo-q
Copy link

jumbo-q commented Oct 19, 2024

image

I want to enable multiple gpus, but it go wrong

# 3. Enable CPU offload for the model.
# turn off if you have multiple GPUs or enough GPU memory(such as H100) and it will cost less time in inference
# and enable to("cuda")

pipe.to("cuda")

# pipe.enable_sequential_cpu_offload()

pipe.vae.enable_slicing()
pipe.vae.enable_tiling()

$ python cli_demo.py --prompt "A girl riding a bike." --model_path THUDM/CogVideoX-5b --generate_type "t2v"
Loading checkpoint shards: 100%|█████████████████████████████████████████████████████████████████████████████████| 2/2 [00:02<00:00, 1.13s/it]
Loading pipeline components...: 100%|████████████████████████████████████████████████████████████████████████████| 5/5 [00:06<00:00, 1.37s/it]
Traceback (most recent call last):
File "/home/ubuntu/gamehub/CogVideo/inference/cli_demo.py", line 177, in
generate_video(
File "/home/ubuntu/gamehub/CogVideo/inference/cli_demo.py", line 99, in generate_video
pipe.to("cuda")
File "/opt/conda/envs/cogvideo/lib/python3.10/site-packages/diffusers/pipelines/pipeline_utils.py", line 396, in to
raise ValueError(
ValueError: It seems like you have activated sequential model offloading by calling enable_sequential_cpu_offload, but are now attempting to move the pipeline to GPU. This is not compatible with offloading. Please, move your pipeline .to('cpu') or consider removing the move altogether if you use sequential offloading.

@zRzRzRzRzRzRzR
Copy link
Member Author

我们正在适配CogVideoX的diffusers版本代码,预计在11月17日左右完成开源工作,届时,显存消耗会大量降低。敬请期待

@zRzRzRzRzRzRzR zRzRzRzRzRzRzR unpinned this issue Nov 10, 2024
@zRzRzRzRzRzRzR zRzRzRzRzRzRzR pinned this issue Nov 10, 2024
@nitinmukesh
Copy link

nitinmukesh commented Nov 19, 2024

Big thanks for your work. The code and all weights works fine on 8GB VRAM. The v1.5 is slow but it's understood as the resolution is high.

Please consider releasing 480x720 resolution models for vertical videos, if possible. The processing time is fast with this resolution.

More users requesting this / want to create vertical videos
#521

@nitinmukesh
Copy link

Requesting to have 2 cli.py for v1 and v1.5 models. I think It's getting confusing regarding resolution, etc. Having different inference file will help.
cli_demo_v1.py
cli_demo_v1.5.py

reference issue: #517

@jiawei243 jiawei243 unpinned this issue Nov 21, 2024
@jiawei243 jiawei243 pinned this issue Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests