Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache all songs on initial load #79

Open
ConcernedHobbit opened this issue Feb 6, 2023 · 3 comments
Open

cache all songs on initial load #79

ConcernedHobbit opened this issue Feb 6, 2023 · 3 comments

Comments

@ConcernedHobbit
Copy link
Collaborator

download all songs' data to cache to allow offline viewing from first page load.

@JaniL
Copy link
Collaborator

JaniL commented Feb 5, 2024

How valuable this is actually? I'm asking because I was considering taking a look at this.

After having a short discussion about this with @hekazu I have a concern if we can justify downloading 868kb of songs on the first load.

@JaniL
Copy link
Collaborator

JaniL commented Feb 5, 2024

So this is actually happening already - all songs are loaded with the default next-pwa configuration.

However I was unable to open the front page while being offline.

@ConcernedHobbit
Copy link
Collaborator Author

yes, the pwa seems to have trouble actually accessing the content. would need to do an in-depth dive on how the pwa (and associated service worker) works to figure out how to get it to function properly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants