Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential_running_standardize bug #56

Open
konspatl opened this issue Jul 26, 2019 · 3 comments
Open

Exponential_running_standardize bug #56

konspatl opened this issue Jul 26, 2019 · 3 comments

Comments

@konspatl
Copy link

Greetings,

I think there's a bug on the "exponential_running_standardize" method in datautil. In the case where there's an init_block_size, the axis of computing the 'init_mean' and 'init_std' is wrong (other_axis gives value 1, although it should be axis=0), as we want to compute the mean and std with respect to time samples, not channels. Although the dimensionality is wrong, the matrix subtraction and division is still possible, which gives wrong results for the init_block_size.

@robintibor
Copy link
Collaborator

@konspatl
Copy link
Author

Yes, it seems so. It's not a significant issue, as it only affects the initial block.

By replacing other_axis with 0 (instead of 1), everything should work fine.

Best regards

@robintibor
Copy link
Collaborator

hm indeed you are very correct. will correct in new braindecode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants