[REQUEST/BUG?] Bump noms not present on most mobs who should have it, probably

[SpadesNeil]

Brief description of the bug

The thing is I'm not clear on if this is a bug or was an intentional feature.

So there's a lot of mobs that should probably have bump vore which don't. That is because over in this part of the code

Rogue-Star/code/modules/mob/mob_defines_vr.dm

Line 12 in 7cff99b

var/faction_bump_vore = FALSE // Don't bump nom mobs of the same faction

faction_bump_vore defaults to FALSE and nothing changes that anywhere in the code. Now mappers can set individual mobs to have bump noms by changing this var from a 0 to a 1 but it doesn't look like anyone has actually done that anywhere.

"But Ace!" I hear you say. "Deer and seagulls and gaslamps and fennecs and probably other vore mobs do bump noms just fine! And they are neutral to the player!" Correct. However, their faction is not actually the same as the player's faction = "neutral" and because the factions are different it can pass this check in the code. Also that's also why if you grab these mobs who aren't really neutral, they get very upset with you most of the time and will retaliate or run away.

This is an easy fix. The reason I haven't fixed it is because I don't know which mobs should have bump noms on by default. Usually this is something left to the mapper but that can probably be very tedious to change. But if you are a mapper, especially in redgate worlds, you should consider setting all of your normally hostile mobs to at least have faction_bump_vore set to 1.

What you expected to happen

When walking into a mob with bump vore on, and that mob is normally hostile, it should do bump noms.

What actually happened

faction_bump_vore is set to 0 and because we're both "neutral" faction bump noms is prevented.

Steps to reproduce

• Find any vore mob that can do bump vore.
• Set its faction var to "neutral"
• Attempt to bump them

This is actually intended functionality according to the code, it just might not make sense to players who are used to it being another way, hence me not being sure if this is a bug or an intentional feature that's just too broad or mappers don't know about.

Code Revision

7cff99b

Anything else you may wish to add:

I'd be happy to meticulously go through the code myself and check every single mob who is set to do bump noms and attempt to change them. I'll even add a toggle to the PET system to allow players to set it when they get their pet, so they can have their pet mob do bump noms if the mob is able to do bump noms in the first place. This could create lots of Fun™ for the server. And if it turns out to be not fun, it'll be easy to remove also.

So why don't I do this? You see I am a dunce and need to re-learn how to pull code off github to edit it.

Also I wanna make sure the changes are actually wanted before I start fiddling.