Fixed issue of verify causing a call on the actual class of the mock …

…due to methods not being open.
TTransmit · Jan 7, 2017 · 46e18b6 · 46e18b6
1 parent 2b4d0f9
commit 46e18b6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 7 deletions.
diff --git a/app/src/main/kotlin/com/example/kotlindaggerunittest/analytics/ThirdPartyAnalyticsWrapper.kt b/app/src/main/kotlin/com/example/kotlindaggerunittest/analytics/ThirdPartyAnalyticsWrapper.kt
@@ -14,15 +14,15 @@ open class ThirdPartyAnalyticsWrapper @Inject constructor() {
         inject()
     }
 
-    fun inject() {
+    open fun inject() {
         MyApplication.myComponent.inject(this)
     }
 
     open fun getMyHello() : String {
         return hello
     }
 
-    fun trackLog(message: String) {
+    open fun trackLog(message: String) {
         thirdPartyLogger.logStuff(message)
     }
 

diff --git a/app/src/test/kotlin/com/example/kotlindaggerunittest/MyNonLifecycleClassTest.kt b/app/src/test/kotlin/com/example/kotlindaggerunittest/MyNonLifecycleClassTest.kt
@@ -5,8 +5,7 @@ import junit.framework.Assert.assertEquals
 import org.junit.Before
 import org.junit.Test
 import org.junit.runner.RunWith
-import org.mockito.Mockito.`when`
-import org.mockito.Mockito.verify
+import org.mockito.Mockito.*
 import org.robolectric.RobolectricGradleTestRunner
 import org.robolectric.annotation.Config
 import javax.inject.Inject
@@ -27,7 +26,6 @@ class MyNonLifecycleClassTest {
         thirdPartyAnalyticsWrapper.inject()
     }
 
-    // This test passes
     @Test
     fun testAnalyticsWrappersTheSame() {
         assertEquals(thirdPartyAnalyticsWrapper, myNonLifecycleClass.thirdPartyAnalyticsWrapper)
@@ -37,11 +35,15 @@ class MyNonLifecycleClassTest {
         assertEquals("test", myNonLifecycleClass.thirdPartyAnalyticsWrapper.getMyHello())
     }
 
-    // This test fails
     @Test
     fun testMakeError() {
         myNonLifecycleClass.makeError()
-        verify(thirdPartyAnalyticsWrapper).trackLog("test")
+        verify(thirdPartyAnalyticsWrapper).trackLog("error")
+    }
+
+    @Test
+    fun testVerifyDoesNotCallItself() {
+        verify(thirdPartyAnalyticsWrapper, never()).trackLog("test2")
     }
 
 }