Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Course setting cannot be saved #1178

Closed
bernhard0309 opened this issue Sep 29, 2023 · 6 comments · Fixed by #1156
Closed

Course setting cannot be saved #1178

bernhard0309 opened this issue Sep 29, 2023 · 6 comments · Fixed by #1156

Comments

@bernhard0309
Copy link

Describe the bug
"Save Settings" Button for Course Settings does not work
To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Settings"
  2. Change Visibility of this course
  3. Click "Save Settings"
  4. Reload page
  5. -> Visibility of this course is not changed

Expected behavior
Save new selected visibility of course

Desktop (please complete the following information):
Windows 10, Edge or Firefox

@alexanderstephan
Copy link
Collaborator

Seems to be due to the rename of a function:
image

@alexanderstephan
Copy link
Collaborator

Cannot reproduce locally with latest dev.

@joschahenningsen
Copy link
Member

ee92bd6 is currently deployed. Maybe this issue only affects lectures with chat enabled?

@joschahenningsen
Copy link
Member

@mono424 was this possibly introduced in #1137?

@mono424
Copy link
Collaborator

mono424 commented Sep 29, 2023

Could be, I tested again with the new Settings PRs, can we merge? Pretty sure this should fix it already :)

@joschahenningsen
Copy link
Member

#1156?

@alexanderstephan alexanderstephan changed the title Visibility of this course cannot be saved Course setting cannot be saved Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants