Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeking with playback rates != 1.0x seeks inappropriate amounts of real time #1252

Open
MariusAlbrecht opened this issue Dec 5, 2023 · 1 comment

Comments

@MariusAlbrecht
Copy link

Describe the bug
Seeking moves 15 seconds in the player. The actual time passed in the recording however depends on the playback rate. This leads to people watching on rates != 1 (especially those higher) to seek forward/backwards inappropriate amounts of real time. For me, e.g., the default seek behavior moves far more than half of a minute (with playback rates >= 2.4) of real time which is pretty useless most times.

To Reproduce
Steps to reproduce the behavior:

  1. play a stream

Expected behavior
always seek (roughly) the same real time and thus seek only seek_time / playback_rate seconds in the player.
I feel like this issue can not be fixed with just #1171 #1234 because that'd require a permanent playback rate

@MariusAlbrecht MariusAlbrecht changed the title Seeking with playback rates != 1.0x Seeking with playback rates != 1.0x seeks inappropriate amounts of real time Dec 5, 2023
@YiranDuan721
Copy link
Contributor

Hi! Thanks for the issue. I'm not sure, by "real time", do you mean the duration of the video, or the time in the real world (so for a 1-minute-long video with 2x playback rate, the real time would be 30 seconds)?
If it's the former one (duration of the video), I didn't manage to reproduce the problem;
For the latter one, I personally think that the current seek behaviour is more natural

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants