Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding shortcuts on the video player buttons controltext #1317

Closed
wants to merge 5 commits into from
Closed

adding shortcuts on the video player buttons controltext #1317

wants to merge 5 commits into from

Conversation

barisgul15
Copy link
Contributor

@barisgul15 barisgul15 commented Jan 22, 2024 •
edited
Loading

Motivation and Context

fixes #1289

Description

  • shortcuts are added to video players buttons. before: play -> after play (k)]
  • keyboard shortcuts should be added to the menu under keyboard icon

Steps for Testing

  1. Log in
  2. Navigate to a Video
  3. Check the text appears when the mouse is on one of the player buttons
  4. Open menu at the home page and click keyboard icon

Screenshots

It used to say only play, not the keyboard shortcuts are also displayed.
New_tooltips_when_mouse_on_video_player_button
Keyboard shortcuts in menu:
Screenshot 2024-01-28 at 23 25 12
Keyboard shortcuts popup:
Screenshot 2024-01-28 at 23 24 34

@barisgul15 barisgul15 linked an issue Jan 22, 2024 that may be closed by this pull request
Showing shortcuts on keyboard for relevant pages #1289
Open
@github-actions GitHub Actions
Copy link

Your Testserver will be ready at https://1317.test.live.mm.rbg.tum.de in a few minutes.

Logins
Kurs1 Kurs2 Kurs3 Kurs4
public public loggedin enrolled
prof1 prof1 prof2 prof1
prof2
student1
student2
student3		 student1
student2		 student2
student3		 student1
student2

@barisgul15 barisgul15 marked this pull request as draft January 22, 2024 13:21
SebiWrn
SebiWrn requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@SebiWrn SebiWrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't create js files directly but rather create Typescript files and include them into the bundles so they get optimized. Please move your js code to the correct typescript files

@SebiWrn
Copy link
Collaborator

SebiWrn commented Sep 23, 2024

If you still want to merge this PR please reopen the PR and fix the issues

@SebiWrn SebiWrn closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SebiWrn SebiWrn SebiWrn requested changes

@alexanderstephan alexanderstephan Awaiting requested review from alexanderstephan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing shortcuts on keyboard for relevant pages
2 participants
@barisgul15 @SebiWrn