Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

userContext menu inconsistent padding #1306

Closed
MariusAlbrecht opened this issue Jan 11, 2024 · 0 comments · Fixed by #1309
Closed

userContext menu inconsistent padding #1306

MariusAlbrecht opened this issue Jan 11, 2024 · 0 comments · Fixed by #1309

Comments

@MariusAlbrecht
Copy link

Describe the bug
the userContext menu menu entries have padding different from the header. I feel like the header has the visually better padding
image
the header has padding 0.5rem 1rem, the menu entries have 0.5rem[ 0.5rem]

To Reproduce
Steps to reproduce the behavior:

  1. Go to Startpage
  2. Click on the user icon at the top right

Expected behavior
image
edited so that both the header and the entries have padding 0.5rem 1rem

Desktop (please complete the following information):

  • OS: ubuntu 23
  • Browser: Firefox 121

Additional info
my browser shows me this in home.css in lines 2752-2755 and 2768-2775 respectively
Frankly I couldnt find the culprit in the repo. Im assuming its tailwinds

.tum-live-menu>header {
  border-bottom-width:1px;
  padding:.5rem 1rem
}
.tum-live-menu .tum-live-menu-item {
 margin-top:.5rem;
 margin-bottom:.5rem;
 display:flex;
 width:100%;
 align-items:center;
 padding:.5rem /* this is the problem */
}
@YiranDuan721 YiranDuan721 linked a pull request Jan 13, 2024 that will close this issue
SebiWrn pushed a commit that referenced this issue Jan 23, 2024
* Align padding of header and items in tum-live-menu (fix #1306)

* Minor changes to tum-live-menu ui

* menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region

* Revert "menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region"

This reverts commit 94fe9f0.

* menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region

* menu item: Make the icons vertically aligned in the center
SebiWrn pushed a commit that referenced this issue May 7, 2024
* Align padding of header and items in tum-live-menu (fix #1306)

* Minor changes to tum-live-menu ui

* menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region

* Revert "menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region"

This reverts commit 94fe9f0.

* menu item: Reduce margin-right, so that the icons don't extend beyond the left boundary of the region

* menu item: Make the icons vertically aligned in the center
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant