Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem on https://docs.typo3.org/m/typo3/reference-typoscript/main/en-us//DataProcessing/MenuProcessor.html #1458

Open
chrcan opened this issue Dec 2, 2024 · 3 comments

Comments

@chrcan
Copy link

chrcan commented Dec 2, 2024

I have noticed that the link target is not available in the menu dataprocessor example, could you please add it to the example?

@linawolf
Copy link
Member

linawolf commented Dec 2, 2024

Thank you for your feedback @chrcan, what link target are you talking about?

@chrcan
Copy link
Author

chrcan commented Dec 2, 2024

here is an example from my MainMenu template that is still missing from your template it's not a big deal but this way it would be complete target="{subItem.target}"

    <f:section name="subMenu">
        <ul class="rd-navbar-dropdown">
            <f:for each="{subMenu}" as="subItem">
                <li class="rd-navbar--has-dropdown rd-navbar-submenu">
                    <f:if condition="{subItem.target}">
                        <f:then>
                            <a href="{subItem.link}" target="{subItem.target}">{subItem.title}</a>
                        </f:then>
                        <f:else>
                            <a href="{subItem.link}">{subItem.title}</a>
                        </f:else>
                    </f:if>
                    <f:if condition="{subItem.children}">
                        <f:render section="subMenu" arguments="{subMenu: subItem.children}" />
                    </f:if>
                </li>
            </f:for>
        </ul>
    </f:section>

@linawolf
Copy link
Member

linawolf commented Dec 3, 2024

Ah, you are talking about the template, I see. In most cases, unless we deal with external links in the menu or something that would blow up the example and is not really the scope of this example (which should be even shorter in my eyes).

We also do not demonstrate for example how to set aria attributes etc as this page only demonstrates the capabilities of the data processor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants