Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The image does not move with the button when I press a PressableButton #14

Open
Sweeper777 opened this issue Oct 1, 2017 · 3 comments
Labels

Comments

@Sweeper777
Copy link

To reproduce this, put a PressableButton on the storyboard, set its image to some image and text to "". Now try to press the button. The button will look like as if it's been pressed, but the image stays at the same position. This looks very unnatural.

@ldiqual ldiqual added the bug label Jan 17, 2018
@ldiqual
Copy link
Contributor

ldiqual commented Jan 17, 2018

Oh good point, we haven't implemented image inset changes in the pressed state. Will tackle soon.

@ldiqual
Copy link
Contributor

ldiqual commented Jan 18, 2018

@Sweeper777 Fixed in f9ec59a which I merged in master. Would you mind giving it a shot with Cocoapods?

pod 'SwiftyButton', :git => '[email protected]:TakeScoop/SwiftyButton.git', :branch => 'master'

@Sweeper777
Copy link
Author

Sweeper777 commented Jan 19, 2018

I can't seem to install the pod. This is the error:

2018-01-19 19 20 35

Also, is this for Swift 3? My old project is still using Swift 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants