Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simplify useForm return type #1016

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: simplify useForm return type #1016

wants to merge 4 commits into from
+58 −10

Conversation

Balastrong
Copy link
Member

An attempt to fix #891

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Nov 12, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 14c0929. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 12, 2024 •
edited
Loading

Open in Stackblitz

More templates

@tanstack/angular-form

pnpm add https://pkg.pr.new/@tanstack/angular-form@1016

@tanstack/form-core

pnpm add https://pkg.pr.new/@tanstack/form-core@1016

@tanstack/react-form

pnpm add https://pkg.pr.new/@tanstack/react-form@1016

@tanstack/lit-form

pnpm add https://pkg.pr.new/@tanstack/lit-form@1016

@tanstack/solid-form

pnpm add https://pkg.pr.new/@tanstack/solid-form@1016

@tanstack/valibot-form-adapter

pnpm add https://pkg.pr.new/@tanstack/valibot-form-adapter@1016

@tanstack/vue-form

pnpm add https://pkg.pr.new/@tanstack/vue-form@1016

@tanstack/yup-form-adapter

pnpm add https://pkg.pr.new/@tanstack/yup-form-adapter@1016

@tanstack/zod-form-adapter

pnpm add https://pkg.pr.new/@tanstack/zod-form-adapter@1016

commit: 14c0929

@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.82%. Comparing base (5473bb8) to head (14c0929).
Report is 159 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1016       +/-   ##
===========================================
- Coverage   91.55%   67.82%   -23.74%     
===========================================
  Files          21       13        -8     
  Lines         900      202      -698     
  Branches      206       50      -156     
===========================================
- Hits          824      137      -687     
+ Misses         71       58       -13     
- Partials        5        7        +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Balastrong Balastrong mentioned this pull request Nov 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Type instantiation is excessively deep and possibly infinite" and tsc crashing
1 participant
@Balastrong