Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@tanstack/lit-virtual does not re-export @tanstack/virtual-core #839

Open
2 tasks done
zemzelett opened this issue Sep 21, 2024 · 0 comments
Open
2 tasks done

@tanstack/lit-virtual does not re-export @tanstack/virtual-core #839

zemzelett opened this issue Sep 21, 2024 · 0 comments

Comments

@zemzelett
Copy link

Describe the bug

The @tanstack/lit-virtual package does not re-export @tanstack/virtual-core as is promised by the documentation and followed upon by all other framework-specific packages.

All the other packages have the following line after the imports:

export * from '@tanstack/virtual-core'

This one missing forces the user to import e.g. types or the defaultRangeExtractor via the peer-dependency @tanstack/virtual-core or to install it as an extra dependency which is undesirable.

Your minimal, reproducible example

https://codesandbox.io/p/devbox/reverent-turing-d43gc7?workspaceId=984f353e-b3d1-46f7-ba8e-c7d667807441

Steps to reproduce

  1. Try to import the defaultRangeExtractor from @tanstack/lit-virtual

Expected behavior

As a user, I expected to be able to import the defaultRangeExtractor and tanstack/virtual types etc. from the @tanstack/lit-virtual package directly.

How often does this bug happen?

Every time

Screenshots or Videos

Image

Platform

all

tanstack-virtual version

v3.10.8

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant