(fix) Cannot exclude multiple tags #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brigidspeed23
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
There's some weird logic with the --excluded-mapping-values logic where it appears to be AND logic for multiple tags. So if you want to exclude tags branches master OR release/packer-core from the cleanup then this isn't possible.
Seems to be a known issue of the repo:
bonclay7#86
bonclay7#95
This fix switches the logic to OR. This is required so we can cleanup the obsolete AMIs in the in the General and Dev Resources account safely.
Related PR: https://github.com/TandaHQ/tanda-infrastructure/pull/1705
QA