Add validation for bank statement line without lines with payment

reference

Author: yamelsenih

base/src/org/compiere/model/MBankStatement.java

@@ -34,6 +34,7 @@
 import org.compiere.util.Env;
 import org.compiere.util.Msg;
 import org.compiere.util.TimeUtil;
+import org.compiere.util.Util;
 
 
 /**
@@ -442,7 +443,48 @@ public String completeIt()
 		if (!isApproved())
 			approveIt();
 		log.info("completeIt - " + toString());
-		
+		StringBuffer linesWithoutReference = new StringBuffer();
+		Arrays.asList(getLines(true)).stream()
+			.filter(statementLine -> statementLine.getC_Payment_ID() == 0)
+			.forEach(statementLine -> {
+				if(linesWithoutReference.length() > 0) {
+					linesWithoutReference.append(Env.NL);
+				}
+				//	Add
+				StringBuffer displayValue = new StringBuffer();
+				displayValue.append(statementLine.getLine());
+				//	Reference No
+				if(!Util.isEmpty(statementLine.getReferenceNo())) {
+					displayValue.append(" - @ReferenceNo@: ").append(statementLine.getReferenceNo());
+				}
+				//	Memo
+				if(!Util.isEmpty(statementLine.getMemo())) {
+					displayValue.append(" - @Memo@: ").append(statementLine.getMemo());
+				}
+				//	EFT Check No
+				if(!Util.isEmpty(statementLine.getEftCheckNo())) {
+					displayValue.append(" - @EftCheckNo@: ").append(statementLine.getEftCheckNo());
+				}
+				if(!Util.isEmpty(statementLine.getEftMemo())) {
+					displayValue.append(" - @EftMemo@: ").append(statementLine.getEftMemo());
+				}
+				//	Add amount
+				if (statementLine.getTrxAmt().compareTo(Env.ZERO) != 0) {
+					displayValue.append(" - @TrxAmt@: ").append(DisplayType.getNumberFormat(DisplayType.Amount).format(statementLine.getTrxAmt()));
+				}
+				if (statementLine.getChargeAmt().compareTo(Env.ZERO) != 0) {
+					displayValue.append(" - @ChargeAmt@: ").append(DisplayType.getNumberFormat(DisplayType.Amount).format(statementLine.getChargeAmt()));
+				}
+				if (statementLine.getInterestAmt().compareTo(Env.ZERO) != 0) {
+					displayValue.append(" - @InterestAmt@: ").append(DisplayType.getNumberFormat(DisplayType.Amount).format(statementLine.getInterestAmt()));
+				}
+				//	Add info
+				linesWithoutReference.append(displayValue);
+		});
+		//	Validate
+		if(linesWithoutReference.length() > 0) {
+			throw new AdempiereException("@Error@" + Env.NL + " @C_Payment_ID@ @NotFound@ " + Env.NL + linesWithoutReference.toString());
+		}
 		//	Set Payment reconciled
 		MBankStatementLine[] lines = getLines(false);
 		for (int i = 0; i < lines.length; i++)