Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 테마별 데일리 루틴 목록 조회(public, 온보딩) 기능 구현 #300

Merged
merged 7 commits into from
Jun 27, 2024
Merged

[FEAT] 테마별 데일리 루틴 목록 조회(public, 온보딩) 기능 구현 #300

merged 7 commits into from
Jun 27, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Jun 26, 2024

✨ Related Issue

📝 기능 구현 명세

image

🐥 추가적인 언급 사항

  • 파라미터 값으로 받은 테마 기준으로 루틴을 조회하는 기능이기 때문에, 테마 정보는 id 외에 생략했습니다.

  • 파라미터 값으로 받은 테마 id 목록 값을 순서 그대로 반환하도록 했습니다.

    • LinkedHashMap 사용
    • stream()이 for문보다 느린 특징과, 사용시 가독성이 크게 향상되지 않는다는 점에서 for문 사용

  • 파라미터 값으로 받는 theme id 목록에서 중복을 허용하지 않기 위해 Set 자료구조를 사용했습니다.

@thguss thguss requested a review from Chan531 June 26, 2024 17:00
@thguss thguss self-assigned this Jun 26, 2024
@thguss thguss added sohyeon 소현 작업 feat 기능 개발 test 테스트 labels Jun 26, 2024
Chan531
Chan531 reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
리뷰 답변 받고 승인하도록 하겠습니다!
(사실 내꺼부터 먼저 머지할라고....ㅋㅋㅋㅋ)

src/main/java/com/soptie/server/routine/controller/v2/docs/DailyRoutineControllerV2Docs.java Show resolved Hide resolved
src/main/java/com/soptie/server/routine/controller/v2/DailyRoutineControllerV2.java Show resolved Hide resolved
.../com/soptie/server/routine/controller/v2/dto/response/DailyRoutineListAcquireResponseV2.java Outdated Show resolved Hide resolved
src/test/java/com/soptie/server/routine/service/integration/RoutineServiceIntegrationTest.java Outdated Show resolved Hide resolved
.../com/soptie/server/routine/controller/v2/dto/response/DailyRoutineListAcquireResponseV2.java Show resolved Hide resolved
src/main/java/com/soptie/server/routine/service/RoutineService.java Show resolved Hide resolved
Chan531
Chan531 approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

답변 모두 확인했습니다!
수고하셨습니다!

@thguss thguss merged commit b902ac3 into develop Jun 27, 2024
2 checks passed
@thguss thguss deleted the feat/#298-acquire-dailyroutines branch June 27, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chan531 Chan531 Chan531 approved these changes

Assignees

@thguss thguss

Labels
feat 기능 개발 sohyeon 소현 작업 test 테스트
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 테마별 데일리 루틴 목록 조회 (in public)
2 participants
@thguss @Chan531