Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] RoutineVO 적용 #303

Merged
merged 6 commits into from
Jun 30, 2024
Merged

[REFACTOR] RoutineVO 적용 #303

merged 6 commits into from
Jun 30, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Jun 28, 2024 •
edited
Loading

✨ Related Issue

📝 기능 구현 명세

  • build-test 대체

🐥 추가적인 언급 사항

  • RoutineVO 적용
  • Challenge(구 HappinessSubRoutine) 쪽은 충돌 이슈 가능성이 있어 우선 백로그로 남겨뒀습니다.

@thguss thguss requested a review from Chan531 June 28, 2024 05:16
@thguss thguss self-assigned this Jun 28, 2024
@thguss thguss added sohyeon 소현 작업 refactor labels Jun 28, 2024
Chan531
Chan531 reviewed Jun 28, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고많으셨습니다!!
리팩토링을 다 하셨네요 ㄷㄷ
리뷰 답변 받고 승인하도록 하겠습니다~!

src/main/java/com/soptie/server/routine/adapter/RoutineFinder.java Show resolved Hide resolved
src/main/java/com/soptie/server/routine/controller/v1/DailyRoutineController.java Show resolved Hide resolved
src/main/java/com/soptie/server/theme/service/ThemeService.java Show resolved Hide resolved
src/main/java/com/soptie/server/routine/repository/RoutineRepositoryImpl.java Show resolved Hide resolved
@thguss thguss requested a review from Chan531 June 29, 2024 20:48
Chan531
Chan531 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

@thguss thguss merged commit 8f6ad44 into develop Jun 30, 2024
2 checks passed
@thguss thguss deleted the refactor/#301-routine-vo branch June 30, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chan531 Chan531 Chan531 approved these changes

Assignees

@thguss thguss

Labels
refactor sohyeon 소현 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thguss @Chan531