Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] 에러 존재시 에러반환하게 #83

Merged
merged 1 commit into from
Nov 23, 2023
Merged

[FIX] 에러 존재시 에러반환하게 #83

merged 1 commit into from
Nov 23, 2023

Conversation

leGit-y
Copy link
Contributor

@leGit-y leGit-y commented Nov 23, 2023

🔎 관련이슈

✨ 변경사항

애플로그인에서 에러발생시 에러를 반환하지 않고 무한로딩되어 time out 되는 문제 존재
authController단 try catch 문에서 catch문 내에 next(error); 를 해주지 않아서 발생하였다,,!
추가로 authService단에서 jwt.verify시 apple의 jwt토큰의 에러 핸들링도 해주기 위해, 해당 부분을 try catch 문으로 감싸주고
에서 발생시, catch문에서 clientException을 throw 하게끔 수정하였다.

📃 참고사항

@leGit-y leGit-y added the Fix Something needs to be fixed label Nov 23, 2023
@leGit-y leGit-y merged commit fc627cb into main Nov 23, 2023
1 check passed
@leGit-y leGit-y deleted the fix/apple branch November 23, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Something needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant