[Bug]: Blurry button iconography.

[RokeJulianLockhart]

What happened?

Almost all button icons - except, sometimes, at some resolutions, the creeper and villager - are blurred:

I'm actually quite surprised that they're interpolated, considering Minecraft's pixellated artstyle. Some lower-resolution icons would be much better if that can't be disabled.

Mod Loader

Forge from https://adfoc.us/serve/sitelinks/?id=271228&url=https://maven.minecraftforge.net/net/minecraftforge/forge/1.19.2-43.4.0/forge-1.19.2-43.4.0-installer.jar

Minecraft Version

1.19.2

Version

5.9.8 from https://www.curseforge.com/minecraft/mc-mods/journeymap/files/5208387

Relevant log output

1. journeymap.log
2. latest.log

[mysticdrew]

Not really a bug, those images likely need sharper versions.

[mysticdrew]

This is the raw image

[RokeJulianLockhart]

#733 (comment)

@mysticdrew, unless you intend to replace them with vectors, or upload 8K rasters, there shall always be a display resolution in use which is higher than the versions contained in the .jar. As an example, most people thought 4K would last more than 4 years until its successor became used in a significant capacity, yet 8K displays amongst the middle and upper classes are weirdly prevalent (I'm still on 1440p, though).

Although vectors would fix this bug permanently, I expect that you don't want to replace the rendering engine used (or if it's not using anything custom, don't want to use a separate engine). However, if that's not used, then you have to disable interpolation somehow, which might be the same dilemma as aforementioned, based upon the versatility of the renderer in use.

The evident response to this absolute thesis on this feature would seem to be "Okay, then I'll just include 8K versions of the icons." However, that doesn't account for devices with memory restrictions, which is a significant amount of users. I can't imagine they want to unnecessarily downscale the icons when rendering the map... Am I missing something?

[mysticdrew]

Minecraft does not provide a way to support rendering of vectors images, at least last I looked. That lwjgl lib was not in the class path.

Also, the image itself is scaled with stb_image to retain the quality as it's enlarged. But the images you are referring to have blurred edges in the raw image.

[RokeJulianLockhart]

#733 (comment)

@mysticdrew, ah, so the original images merely need to be re-exported without the Gaussian anti-aliasing (because I imagine you're implying that stb_image doesn't interpolate)?

[mysticdrew]

Correct, but I don't have the original anymore.

STBImageResize.nstbir_resize_uint8_generic(
                from.pixels,
                from.getWidth(),
                from.getHeight(),
                0,
                scaledImage.pixels,
                scaledWidth,
                scaledHeight,
                0,
                from.format().components(),
                STBIR_ALPHA_CHANNEL_NONE,
                0,
                STBIR_EDGE_CLAMP,
                STBIR_FILTER_BOX,
                STBIR_COLORSPACE_LINEAR,
                0L);

This is stb image function we use for scaling the theme images

[mysticdrew]

You can swap the images your self here. minecraft/jourenymap/icon/theme/flat/icon